Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable select for events from external calendars #3289

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Dec 10, 2024

Short description

This Pr disables the select button in the event form for events that have been imported from external calendars.

Proposed changes

  • Disable dropdown when it's from an external calendar

Side effects

This has been worked on in collaboration with @KateGithub12

Resolved issues

Fixes: #3204


Pull Request Review Guidelines

Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Unfortunately this does not fix the case when an event is not imported, but archived

@JoeyStk JoeyStk force-pushed the bug/fix-disabled-select branch 2 times, most recently from e8ebcb8 to 28564d0 Compare December 17, 2024 16:23
@JoeyStk
Copy link
Contributor Author

JoeyStk commented Dec 17, 2024

@david-venhoff Thank you very much for the explanation. The suggestion is applied now, could you please check if everything is okay now? Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekdays selector of recurrence rule form never gets disabled
3 participants